Fix updateChart() missing filter expressions map #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a filter is applied, updateChart() should not be called without the filter expression map. Replace method updateSearchFilters(), which computes the filter expression map and calls updateChart with the map if it applies, with method filterExpressionsMap() which only computes the map. This method is now always called to compute the parameter to be passed in updateChart(). Remove the updateSearchFilters callback when adding or removing a filter as the state change will handle it already. Method _debouncedUpdateSearch() is removed, as _debouncedUpdateChart() can always be used instead. Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse
force-pushed
the
filtersmap
branch
from
a5ddfb9 to
349af1f
Compare
bhufmann
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a filter is applied, updateChart() should not be called without the
filter expression map.
Replace method updateSearchFilters(), which computes the filter
expression map and calls updateChart with the map if it applies, with
method filterExpressionsMap() which only computes the map. This method
is now always called to compute the parameter to be passed in
updateChart().
Remove the updateSearchFilters callback when adding or removing a filter
as the state change will handle it already.
Method _debouncedUpdateSearch() is removed, as _debouncedUpdateChart()
can always be used instead.